Skip to content

fix(match2): match summaries with bracket reset overflow popup height#7683

Open
ElectricalBoy wants to merge 4 commits into
mainfrom
match2-bracket-reset-broken-height
Open

fix(match2): match summaries with bracket reset overflow popup height#7683
ElectricalBoy wants to merge 4 commits into
mainfrom
match2-bracket-reset-broken-height

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

Fixes #7682

Mainly inspired by #7682 (comment)

How did you test this change?

browser dev tools

ElectricalBoy and others added 4 commits June 22, 2026 11:34
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
@ElectricalBoy ElectricalBoy requested review from a team June 22, 2026 03:09
@ElectricalBoy ElectricalBoy added c: match2 stylesheets Changes to stylesheets labels Jun 22, 2026
}

.toggle-area & {
max-height: calc( 100dvh - ( 2.75rem + 4.1875rem + 3.5rem ) ); // 3.5rem for the switcher (compared to .brkts-popup.brkts-match-info-popup)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a comment to explain what the other deductions are for?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are copied from .brkts-popup.brkts-match-info-popup :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bracket reset match is breaking scroll in chess match summary

3 participants